Question

I am logging in using a username and password and this is my code in DAL

public static SqlDataReader login(SchoolBAL bal)
 {
  SqlConnection con = DBConnection.OpenConnection();
  try
   {
   int i;
   SqlCommand cmd1 = new SqlCommand("login", con);
   cmd1.CommandType = CommandType.StoredProcedure;
   cmd1.Parameters.AddWithValue("@username", bal.UserName);
   cmd1.Parameters.AddWithValue("@password", bal.Password);
   SqlDataReader dr = cmd1.ExecuteReader();
   return dr;
   }catch (Exception)
    {
      throw;
    }
 }

but i want to return an integer here how can i do it?

EDIT::

    Create procedure login
(@username varchar (50),@password varchar (50))

as
begin
select UserName,password from tblLogin where UserName=@username and password=@password
end

Answer 1

You’re returning the reference of DataReader but return type of method is int. Change the return type of method.

public static bool login(SchoolBAL bal)
{
  bool isFound=false;
  using(SqlConnection con = DBConnection.OpenConnection())
   {
    using(SqlCommand cmd1 = new SqlCommand("login", con))
    {
     cmd1.CommandType = CommandType.StoredProcedure;
     cmd1.Parameters.AddWithValue("@username", bal.UserName);
     cmd1.Parameters.AddWithValue("@password", bal.Password);
     con.Open(); 
     SqlDataReader dr = cmd1.ExecuteReader();
     if(dr.Read())
       isFound=true;
     dr.Close();
     con.Close();
     }
    }
  return isFound;
}