Question

I am looking at code that has been created and it uses a TryEnter in one method call and lock in others. So, like this:

private readonly object xmppLock = new object();

void f1() 
{
    if (Monitor.TryEnter(xmppLock))
    {
        try
        {
            // Do stuff
        }
        finally
        {
            Monitor.Exit(xmppLock);
        }
    }
}

void f2()
{
    lock(xmppLock)
    {
        // Do stuff
    }
}

Is this okay?

Answer 1

lock will block until the resource is available

TryEnter will not do anything if it is already locked.

Depending on your needs you have to use one or the other.

In your case f2() will always do what ever it does no matter how long it takes. f1() will return immediately if there is lock contention