Question

I am looking for a better way to update values in my List/Array:

My code is like –

String[] values = baseValue.Split(new []{'+'}); 

Because the ‘values’ can have decimal/string values – I want to update items in this list to remove any value after decimal –

for (int i = 0; i < values.Count(); i++)
{
    decimal newvalue;
    if (Decimal.TryParse(values[i], out newvalue))
    {
        values[i] = Decimal.ToInt32(newvalue).ToString();
    }
}

Is there a better way to achieve above using Linq/without Linq ?

Answer 1

You could use string operations, instead of converting to decimal then to int and finally back to string.

string[] values = baseValue.Split('+');
for (int i = 0; i < values.Length; i++)
{
    int pos = values[i].IndexOf('.');
    if (pos >= 0) {
        values[i] = values[i].Substring(0, pos);
    }
}

Of cause no rounding occurs here.

---

String.Split has an overload with one argument params char[] separator. Because of the params keyword, you can specify as many characters as you want, without having to create an array explicitly.

string[] result = s.Split('x', 'y', 'z');

---

Use values.Length which is a property built into array types. values.Count() is a LINQ extension method, which enumerates all the array items and is therefore not efficient.