Question

I am looking to insert records from xml into two different tables.
For example

<Root>
    <A>
        <AValue>value</AValue>
        <Children>
            <B>
                <BValue>2</BValue>
            </B>
        </Children>
    </A>
    <A>
        <AValue>value</AValue>
        <Children>
            <B>
                <BValue>3</BValue>
            </B>
        </Children>
    </A>
</Root>

Would insert a record into table A
Assuming the identity is starting at 1

AID  AValue
1    value
2    value

also insert a record into table B

BID AID  BValue
1   1    2
2   2    3

I have this

DECLARE @idoc INT
DECLARE @doc NVARCHAR(MAX)

SET @doc = '
<Root>
    <A>
        <AValue>value</AValue>
        <Children>
            <B>
                <BValue>2</BValue>
            </B>
        </Children>
    </A>
     <A>
        <AValue>value</AValue>
        <Children>
            <B>
                <BValue>3</BValue>
            </B>
        </Children>
    </A>
</Root>
'

EXEC sp_xml_preparedocument @idoc OUTPUT, @doc

CREATE TABLE #A
    (
      AID INT IDENTITY(1, 1) ,
      AValue varchar(100)
    )

INSERT  INTO #A
        SELECT  *
        FROM    OPENXML (@idoc, '/Root/A',2)
                WITH (AValue varchar(100)
                      )  

CREATE TABLE #B
    (
      BID INT IDENTITY(1, 1) ,
      AID INT ,
      BValue INT
    )

INSERT  INTO #B
        SELECT  *
        FROM    OPENXML (@idoc, '/Root/A/Children/B',2)
                WITH (
                AID INT,
                BValue INT
                      )

SELECT  *
FROM    #A
SELECT  *
FROM    #B

DROP TABLE #A
DROP TABLE #B
exec sp_xml_removedocument @idoc

Thanks!

Answer 1

You need to maintain correlation, which the below shows you how to do. I also made it more robust by adding quite a few bits of flexibility.

DECLARE @A table
    (
-- start with non-1, to show the solution is not dependent on starting at 1
      AID INT IDENTITY(14, 1) ,
      AValue varchar(100)
    )
DECLARE @B TABLE
    (
      BID INT IDENTITY(1, 1) ,
      AID INT ,
      BValue INT
    )

DECLARE @xml XML

-- allow for duplicate values on A.AValue
-- allow for multiple B nodes
-- allow for A nodes without B children
SET @xml = '
<Root>
    <A>
        <AValue>value2</AValue>
        <Children>
            <B>
                <BValue>2</BValue>
            </B>
            <B>
                <BValue>4</BValue>
            </B>
        </Children>
    </A>
     <A>
        <AValue>value1</AValue>
        <Children>
            <B>
                <BValue>3</BValue>
            </B>
        </Children>
    </A>
     <A>
        <AValue>value1</AValue>
        <Children>
            <B>
                <BValue>9</BValue>
            </B>
        </Children>
    </A>
     <A>
        <AValue>valueX</AValue>
    </A>
</Root>
'

-- dump the data into a temp table for correlating A and B entries
-- since an A can have multiple B children, ARow identifies which A it really is,
--    multiple A records can have the same AValue

declare @tmp table (ARow int, avalue varchar(100), bvalue int)
INSERT @tmp (ARow, avalue, bvalue)
SELECT X.N, X.C.value('A[1]/AValue[1]','varchar(100)'), Y.V
FROM (
    SELECT T.C.query('.') C, row_number() over (order by C) N
    FROM @xml.nodes('//A') T(C)) X
OUTER APPLY (
    SELECT T2.C2.value('.','int') V
    FROM X.C.nodes('A[1]/Children/B/BValue') T2(C2)) Y

-- uncomment next line to see what has gone into @tmp
-- select * from @tmp

insert @A
select AValue
from (
    select distinct ARow, AValue
    from @tmp) X
order by ARow -- order by is important to maintain correlation

-- get the last identity generated to correlate AID in B
declare @lastid int
SET @lastid = scope_identity()

-- Max(ARow) is how many A records were entered, add back ARow to get
-- the ID generated for the A record

insert @B (AID, BValue)
select @lastid-M.M+ARow, BValue
from @tmp, (select max(ARow) M from @tmp) M
where BValue is not null
order by ARow

-- check results
select * from @A
select * from @B