Question

I am looping through a list of objects and changing some of the values. When I output the value into the logger, I see the changed values, but when then on the resulting page, the changes do not get saved.

Here is my loop:

@dis.each do |d|
  temp = d.notes.inspect

  #Now check the length of the temp variable
  temp.length > 25 ? temp = temp[0,25] :  nil

  d.notes = temp
end

How do I change it so that the new values of temp get saved in the @dis object?

Thanks!

Answer 1

You can get the result you want using collect! or map! to modify the
array in-place:

https://stackoverflow.com/a/5646754/643500

x = %w(hello there world)
x.collect! { |element|
  (element == "hello") ? "hi" : element
}
puts x

Edit:

So for your code it will look like

@dis.collect! do |d|
  temp = d.notes.inspect

  #Now check the length of the temp variable
  temp.length > 25 ? temp = temp[0,25] : temp = nil

  d.notes = temp
end

Edit:

Full code that worked here. Make sure you have :notes with getters and setters. Read about cattr_accessor, attr_accessor and attr_accessible

class TestClass
  @note
  def initialize note
    @note = note
  end
  def get_note
    @note
  end
  def set_note note
    @note = note
  end
end

@dis = Array.new
@dis << TestClass.new("yo yo")
@dis << TestClass.new("1 2 3 4 5 6 7 8 9 10 6 7 8 9 10 6")
@dis << TestClass.new("a b c")

@dis.collect! do |d|
  temp = d.get_note.inspect

  #Now check the length of the temp variable
  d.get_note.inspect.length > 25 ? d.set_note(temp[0,25]) : d.set_note(nil)

end


puts "#{@dis}"