Question

I am receiving the following error when running my below ruby script:

s3parse.rb:12:in `block in <class:AccountLog>': undefined method `extract_account_id' for AccountLog:Class (NoMethodError)

I dont think it should be a class method, is there a reason its not taking my method into account?

class AccountLog
attr_accessor :bytes, :account_id, :date

    def extract_account_id(line)
            line.match(%r{accounts/(\d+)}).captures.join.to_i
    end

    s3log = File.open('vidcoder.txt').each do |line|
        account_log = AccountLog.new
        account_log.date = line.match(%r{\[[^:]*}).to_s.delete"[" #need to finish this regex to make it work
        account_log.account_id = extract_account_id(line)
        account_log.bytes = line.match(%r{^.*\s+HTTP.*\s+-\s+(\d+)\s+}).captures.join.to_i
        puts "\n" 
        puts "The api request on #{account_log.date} was fromm account number #{account_log.account_id} and the bytes were #{account_log.bytes}"
    end

end

Answer 1

def extract_account_id will define an instance method.

In the way you call it, you need a class method instead.

Define it like this:

def self.extract_account_id(line)

or, as you already have an AccountLog instance, use it to call extract_account_id:

account_log.account_id = account_log.extract_account_id(line)

Please note that with second way you do not need to alter method definition, just call extract_account_id via account_log instance.

And i guess you would want to put s3log = File... outside class definition.

Or use a constant instead: S3log = ...

Then you’ll can access it as AccountLog::S3log