Question

I am storing the status of togglebutton using a sharedpreffrence.
I am putting “ON” if toggle button is checked and “OFF” if toggle button is unchecked.
But when I am retriveing the status , it always returns “ON”
Here is the code

SharedPreferences.Editor  shfEditMessageSMS;
SharedPreferences  shfResponderMessage;
shfResponderMessage=getSharedPreferences("MESSAGE", Context.MODE_PRIVATE);
shfEditMessageSMS=shfResponderMessage.edit();

toggleStatus=(ToggleButton)findViewById(R.id.toggleButtonStatus);

toggleStatus.setOnClickListener(new View.OnClickListener()
{           
    public void onClick(View v)
    {
        // TODO Auto-generated method stub
        if(((ToggleButton)v).isChecked())
        {
            shfEditMessageSMS.putString("SMSRESPONDERONOFF", "ON");
            shfEditMessageSMS.commit();

            showNotification("ON");                   
        }
        else
        {
            shfEditMessageSMS=shfResponderMessage.edit();
            shfEditMessageSMS.putString("SMSRESPONDERONOFF", "OFF");
            shfEditMessageSMS.commit();

            showNotification("OFF");
            String SMSResponderOnOrOff=shfResponderMessage.getString("SMSRESPONDERONOFF", "NONE");
            Log.i("SMS Responder on click "+SMSResponderOnOrOff," "); 
        }
    }
});

As you can see in the code that if toggle button in unchecked i am doing

shfEditMessageSMS.putString("SMSRESPONDERONOFF", "OFF");
shfEditMessageSMS.commit();

but when I am retrieving and printing using log

String SMSResponderOnOrOff=shfResponderMessage.getString("SMSRESPONDERONOFF", "NONE");
Log.i("SMS Responder on click "+SMSResponderOnOrOff," ");

It always shows “ON” in the logs.

What could be the problem.
thanks.

Answer 1

i have implement the Same thing in my application. Might Help you out to Solve your Problem.Though Could Not able to Find out the Mistake you have done in your Code. Refere below code below.

boolean on; 
 public SharedPreferences spref; 
  final String PREF_NAME="preferences"; 
 ToggleButton tb;

@Override protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState); 
    setContentView(R.layout.fb_intermidiate);
    spref = getSharedPreferences(PREF_NAME, MODE_PRIVATE);
    tb = (ToggleButton) findViewById(R.id.toggleButton1);
    on = spref.getBoolean("On", true);  //default is true
    if (on = true) 
    {
      tb.setChecked(true);
    }       else
    {
      tb.setChecked(false);
    }
    back = (Button)findViewById(R.id.button_back); 
    //back.setText(R.string.back_button_in_settings);
    back.setOnClickListener(new View.OnClickListener() {

        public void onClick(View v) {
            // TODO Auto-generated method stub
            finish();
        }
    });  } 

public void onToggleClicked(View view) {

    on = ((ToggleButton) view).isChecked();
    if (on) {
        Toast.makeText(this, "On : Notification will be Enabled", Toast.LENGTH_SHORT).show();
        SharedPreferences.Editor editor = spref.edit();
        editor.putBoolean("On", true); // value to store
        editor.commit();

    } else {
    Toast.makeText(this, "Off : Notification will be Disabled", Toast.LENGTH_SHORT).show();
        SharedPreferences.Editor editor =spref.edit();
        editor.putBoolean("On", false); // value to store
        editor.commit();
    }   }