Question

i am stuck with my first GCD and first core-data using application =)

two views access the same data (which is handled by a single DAO).

if i wait for the current view to finish loading its content no problem occors when changing view.

however: if i change the view (its tabbased) while one controller tries to fetch data from my model, the new controller tries the same and the threads ‘collide’ and my application freezes.

the freeze occurs in this line of code of my DAO:

    NSArray *results = [managedObjectContext executeFetchRequest:fetch error:&error];    

reloadAllMonth() accesses the fetch routine of my DAO

how i load the data in the first controller:

dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^(void) {
                [self reloadAllMonth];

                dispatch_async(dispatch_get_main_queue(), ^(void) {                        
                    [self.allMonthTable reloadData];    
                });

in the second viewcontroller the first thing i do is update my DAO, this of course uses (beneath others) the very same fetch routine i called before:

    [self.dataHandler updateData];

i have tried two approaches so far:

first using a c-semaphore:

-(NSArray *)fetchAllMonthExpenses{  
    //@return: array of all expenses in month (day & month type)


    NSNumber *monthNumber = [self getMonthNumber:[NSDate date]];
        NSEntityDescription *exp = [NSEntityDescription entityForName:@"Expense" inManagedObjectContext:managedObjectContext];
    NSFetchRequest *fetch = [[NSFetchRequest alloc]init];
    [fetch setEntity:exp];
    [fetch setPredicate:[NSPredicate predicateWithFormat:@"month == %@",monthNumber]];
    NSError *error = nil;
    sem_wait(&isLoading);
    NSArray *results = [self.managedObjectContext executeFetchRequest:fetch error:&error];  
    sem_post(&isLoading);
    return results;

}

second using the synchronized directive

-(NSArray *)fetchAllMonthExpenses{  
    //@return: array of all expenses in month (day & month type)


    NSNumber *monthNumber = [self getMonthNumber:[NSDate date]];
        NSEntityDescription *exp = [NSEntityDescription entityForName:@"Expense" inManagedObjectContext:managedObjectContext];
    NSFetchRequest *fetch = [[NSFetchRequest alloc]init];
    [fetch setEntity:exp];
    [fetch setPredicate:[NSPredicate predicateWithFormat:@"month == %@",monthNumber]];
    NSError *error = nil;
    @synchronized(self.class){
        NSArray *results = [self.managedObjectContext executeFetchRequest:fetch error:&error];  
        return results;
    }    
}

sadly both of the approaches did not work, the application freezes whatever i do.

so my question is: what am i doing wrong (as i mentioned first time using threads), what am i missing, where should i look?

this has been keeping me busy for 2 days now and i cant seem to wrap my head around it :/

Answer 1

An NSManagedObjectContext and all of the NSManagedObjects inside it are not thread safe.

Whatever thread you use to create the context, that needs to be the only thread where you do anything relating to that context. Even just reading values from one of the managed object must be done on that thread and not on any other thread.

If you need two threads which both deal with the same database, you’ve got two options:

• use dispatch_sync() to jump into the other thread momentarily to perform all read/write operations on the managed objects and/or the context

Or:

• create a second NSManagedObjectContext in the other thread for the same database, and keep any changes made to the two contexts in sync.

The first option is much easier, but may remove much of the benefits of threading. The second option is harder, but it can be done, and there is a fairly good API for keeping two contexts on different threads in sync.

Lookup the Core Data Programming Guide for more details.