Question

I am try to control multiple strings variables is empty or not at once:

My first approach is very simple:

if(string.isNullOrEmpty(val1) && string.isNullOrEmpty(val2) && string.isNullOrEmpty(val3))

My second way looks like this

if(string.isNullOrEmpty(val1 + val2 + val3))

Which one is fastest and elegant?
Is there any options to do this operation?

Answer 1

The first was faster in my test (just had to): 6ms vs. 70ms and that was on 10,000,000 iterations each (so the speed difference probably doesn’t matter very much unless you’re doing this on a massive scale).
Anyway, i find the first to be more clear.

Also it doesn’t rely on behavior of IsNullOrEmpty that is not immediately obvious (you might just as well think that passing null parameters causes an ArgumentNullException if you don’t know better), which i think is important.

Note: The test was with all variables set to null, but setting them to other values confirms it, the longer the strings get, the longer option 2 takes, while option 1 stays at about 30ms max.

Also, the first returns true if any of the strings is null or empty, while the second does it only if all of them are null or empty. So it’s not the same check.