Home/ Questions/Q 9024405
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-16T06:00:00+00:00

I am trying to add a custom error to an instance of my User

  • 0

I am trying to add a custom error to an instance of my User model, but when I call valid? it is wiping the custom errors and returning true.

[99] pry(main)> u.email = "test@test.com"
"test@test.com"

[100] pry(main)> u.status = 1
1

[101] pry(main)> u.valid?
true

[102] pry(main)> u.errors.add(:status, "must be YES or NO")
[
    [0] "must be YES or NO"
]

[103] pry(main)> u.errors
#<ActiveModel::Errors:[...]@messages={:status=>["must be YES or NO"]}>

[104] pry(main)> u.valid?
true

[105] pry(main)> u.errors
#<ActiveModel::Errors:[...]@messages={}>

If I use the validate method from within the model, then it works, but this specific validation is being added from within a different method (which requires params to be passed):

User

def do_something_with(arg1, arg2)
  errors.add(:field, "etc") if arg1 != arg2
end

Because of the above, user.valid? is returning true even when that error is added to the instance.

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    In ActiveModel, valid? is defined as following:

    def valid?(context = nil)
  current_context, self.validation_context = validation_context, context
  errors.clear
  run_validations!
ensure
  self.validation_context = current_context
end

    So existing errors are cleared is expected. You have to put all your custom validations into some validate callbacks. Like this:

    validate :check_status

def check_status
  errors.add(:status, "must be YES or NO") unless ['YES', 'NO'].include?(status)
end
    • 0