Question

I am trying to find maximum number from a loop and it’s number of occurrences. Here is the code I have written so far.

public class MaxNumbers {
    public static void main(String[] args) {
        Scanner input = new Scanner(System.in);
        int max = 0;
        int number = 0;
        int count_max = 0;
        while (true) {
             number = input.nextInt();
            if (number == 0) {
                break;
            }
            number = max;
            if (max > number) {
                max=number;
                count_max++;
            }

        }
        System.out.println("Max Number: " + number);
        System.out.println("Occurences: " + count_max);
    } 

I getting only zero in the output, any logical error I am making?

Answer 1

This is my version of what I think you are trying to achieve, it is mostly working, please note that you have to start typing in numbers if you start with a string it fails as you describe, also note numbers larger then long get ignored or ‘trimmed’

import java.util.Scanner;

public class Test {

    public static final void main(String[] args) {
        long a = 0, b = 0, c = 0, d = 0;

        System.out.println("Type some numbers!");

        Scanner sc = new Scanner(System.in);
        String in = sc.nextLine();
        Scanner ln = new Scanner(in);

        while (ln.hasNextLong()) {
            a = ln.nextLong();
            if (a > b) {
                b = a;
                ++d;
            }
            ++c;
        }

        System.out.println("\n   info:");
        System.out.println("     highest:" + b);
        System.out.println("     iterations:" + c);
        System.out.println("     overrides:" + d);
    }
}