Question

I am trying to insert messages to a function

function addMessage($item) {
     if ($result) {
      $message =  '<p class="ok">
                    <span> Item added </span>
                   </p>
                  ';
                  header("Refresh: 2; url=?page=$item");
        }
        else{
            $message = '<p class=not><span>There is an error blah blah</span></p>';
        }
        return $message;

}

When I use it : addMessage(‘contents’) it only returns to second condition. How can I fix this?

Answer 1

Hi jasmine

Your function always returns the second condition because you haven’t assigned a value to $result, eider inside the function or when you call the function (like unicornaddict mentioned by other words).

To get your code working the way you probably want, your function should be like this:

function addMessage($item, $result) {
     if ($result) { // It will return this condition, case $result has any value assigned and is different from FALSE (boolean)
      $message =  '<p class="ok">
                    <span> Item added </span>
                   </p>
                  ';
                  header("Refresh: 2; url=?page=$item");
        }
        else{ // It will return this condition, case $result doesn't has any value assigned or is equal to FALSE (boolean)
            $message = '<p class="not"><span>There is an error blah blah</span></p>';
        }
        return $message;
}

And then you can call the function like you where already calling it, but don’t forget to include a variable or a value that should be handled as the $result variable inside the function

addMessage('contents', $result);

Note:

In your $message variable you have <p class=not> and should be <p class="not">.

Remember that header() must be called before any actual output is sent to the browser.

Hope it Helps.