Question

I am trying to make a vbs work, the idea is it will remotely install an msi, to a list of machines contained with a txt file.

I am getting multiple errors, the first is:

wrong number of arguments or invalid property assignment: “WshShell.Exec” Line 27, Char 1

WshShell.Exec "%COMSPEC% /C COPY " & StrInstallFile & " \\" & strComputer _
  & "\C$\Windows\Temp", 0, TRUE 

I seemd to have got round this with:

Set WshExec = WshShell.Exec......

then got:

expected end of statement line 27 cahr 29

adding an &:

Set WshExec = WshShell.Exec & "%COMSPEC%.....

now gets me:

expected end of statement line 27 char 110

which is the penultimate comma

Set WshExec = WshShell.Exec & "%COMSPEC% /C COPY" & StrInstallFile _
  & " \\" & strComputer & "\C$\Windows\Temp", 0, TRUE

so i am not sure what is wrong at this point, and whether changing the whole line to a set was the right thing to have done.

Answer 1

You are mixing .Run and .Exec. The prototype for .Exec:

object.Exec(strCommand)

shows that you need someting like:

Set oExec = WshShell.Exec("%COMSPEC% /C COPY " & StrInstallFile & " \" & strComputer & "\C$\Windows\Temp")

If you want .Run instead, try something like:

Dim iRet : iRet = WshShell.Run(strCommand, [intWindowStyle], [bWaitOnReturn]) 
Dim iRet : iRet = WshShell.Run("%comspec% ...", 0, True)