Question

I am trying to replace the id of a jQuery element for the next one as follows:
‘foo-1’ –> ‘foo-2’

And I finally ended with this:

$(this).attr('id',$(this).attr('id').replace(/-[0-9]*/,'-'+(parseInt($(this).attr('id').substring($(this).attr('id').indexOf('-')+1,$(this).attr('id').length))+1)));

Ugly, right?
Any Ideas of how I would improve this…..?

Answer 1

Use the replace callback function to simplify your code:

this.id = this.id.replace(/(-)(\d)*/, function ($1,$2,$3,$4) {
  console.log(arguments);
  var index = parseInt($3,10);
  return $2 + ++index + "";
});

$2 matches the first parentheses (which is ‘-‘ in your case), $3 matches the digitals. You then prase the digital with parseInt() and increment it by one. Finally, you put together the replaced string with + string operator.