Question

I am trying to run a shell function to open a file using Notepad.exe

I get the “invalid procedure call or argument shell” error when trying to open a file.

Sub OpenTextFile(textfile$)
  Dim txtapp$, arg$
  txtapp = "Notepad.exe"
  textfile = "C:\Users\ADMIN\Desktop\USA - FLNG\modelout\SUMMER.CFS"
  arg = Trim$(txtapp & " " & Chr$(34) & Trim$(textfile) & Chr$(34))
  ierr = Shell(arg, vbNormalFocus)
End Sub

Any ideas?

Answer 1

This worked for me:

Sub OpenTextFile(textfile As String)

Const txtapp As String = "Notepad.exe"
Dim arg As String
Dim ierr As Double

  arg = Trim$(txtapp & " " & Chr$(34) & Trim$(textfile) & Chr$(34))
  ierr = Shell#(arg, vbNormalFocus)

End Sub

Type-declaration characters are considered legacy code, so I avoid them with declarations. (However I used them with Shell/Trim/Chr to avoid the Variant return type.)

I believe the error you are experiencing is because your filepath contains spaces. Try the WSHOM instead:

Sub OpenTextFile(textfile As String)
Dim oShell As Object

  Set oShell = GetShell

  If Not oShell Is Nothing Then
    oShell.Run textfile
  End If
End Sub

Function GetShell() As Object
  On Error Resume Next  
  Set GetShell = CreateObject("WScript.Shell") 
End Function