Question

I am trying to select a sheet from the workbook that has the newest date. The date is in the same space for each sheet, otherwise it is blank or text, and therefore should never evaluate as greater than an integer or date formatted value i think. Once i have found that sheet i want to take specific data and use it. My problem is selecting the correct sheet. Here is the code:

Dim wksht As Worksheet
Dim maxsheet As Worksheet
Dim currentdate as Integer
Dim maxdate as Integer

'go through each worksheet. compare the value of current date extracted from each sheet
'to maxdate. If currentdate > maxdate maxdate = currentdate.
'remember the worksheet for maxdate as maxsheet.

maxdate = 0
For Each wksht In ActiveWorkbook.Worksheets
    With wksht
        currentdate = wksht.Range("B1").Value
        If currentdate > maxdate Then
            maxsheet = wksht
            maxdate = currentdate
        End If
    End With
Next wksht

What is going on? The error i get is “’91’: Object variable or with block variable not set.” I don’t really understand the help section or how i can fix it.

Looking at the code again i foresee another problem, working with the sheet once i have the sheet stored. Can i just use maxsheet.select for that?

Answer 1

The loop logic looks good to me. You’re correct that the With wksht/End With are not being used. To use, it would be:

For Each wksht In ActiveWorkbook.Worksheets
    With wksht
        currentdate = .Range("B1").Value ` <~~~~ This guy right here
        If currentdate > maxdate Then
            maxsheet = wksht
            maxdate = currentdate
        End If
    End With
Next wksht

Now, without knowing a bit more about your worksheets I’m not sure I can answer your problem specifically, however, I would redo the logic to something like this:

[Untested]

Dim currentdate as Date
Dim maxdate as Date
For Each wksht In ActiveWorkbook.Worksheets
    if IsDate(wksht.Range("B1").Value) then    
        currentdate = CDate(wksht.Range("B1").Value)
        If currentdate > maxdate Then
            set maxsheet = wksht
            maxdate = currentdate
        End If
    end if
Next wksht

http://p2p.wrox.com/access-vba/11341-convert-text-date-time-access.html