Question

I am trying to show text content just with a PHP if condition but I have several errors and I don’t see where is the error could someone help me with this, here is the code:

<?php
  if(
     isset($_POST['send']) &&
     !validateDiscp($_POST['Discp']) || !validateSize($_POST['Size'])
  ) : ?>

<div id="error">
  <ul>
    <?php if(!validateDiscp($_POST['Discp'])):?>
     <li><strong>Discription:</strong>Discription need to be larger then 10!</li>
    <?php endif?>
    <?php if(!validateSize($_POST['Size'])):?>
     <li><strong>Invalid Size:</strong> Size needs to bi S M L XL</li>
    <?php endif ?>
      </ul>
</div>

<?php elseif(isset($_POST['send'])):?>
<div id="error" class="valid">
  <ul>
    <li><strong>Congratulations!</strong> All fields are OK ;)</li>
  </ul>
</div>
<?php endif ;?>

Answer 1

I would rewrite the whole outside block. Instead do:

 <? if( isset($_POST['send'])&&  !validateDiscp($_POST['Discp']) || !validateSize($_POST['Size']) ) { ?>
        <div id="error">
            <ul>
               <?php if(!validateDiscp($_POST['Discp'])) { ?>
                    <li><strong>Discription:</strong> Discription need to be larger then 10!</li>
                <?php } ?>
                <?php if(!validateSize($_POST['Size'])) { ?>
                    <li><strong>Invalid Size:</strong> Size needs to bi S M L XL</li>
                <?php } else { 
        $nothing = true;
                 ?>



            </ul>
        </div>

    <?php if( isset( $nothing ) and isset($_POST['send'] ) ) { ?>
        <div id="error" class="valid">
            <ul>
                <li><strong>Congratulations!</strong> All fields are OK ;)</li>
            </ul>
        </div>

     <? } ?>

I think the flaw in your logic ist hat you have an else statement that is dangling. Instead add a little logic to detect when the else case is hit and add your additional logic and your good to go.