Question

I am using a API that has a macro for success which is “NT_SUCCESS”. However they don’t have one for failure. So normally I have to do this.

if(something failed)
    return !NT_SUCCESS;
else
   return NT_SUCCESS;

Having the !NT_SUCCESS I don’t think is very readable. So I decided to do this:

#define SUCCESS NT_SUCCESS
#define FAILURE (!NT_SUCCESS)

EDIT =============================

#define ENT_NOERR 0 /* No error */ 
#define NT_SUCCESS ENT_NOERR /* synonym of ENT_NOERR */ 

This is how NT_SUCCESS is declared, Would it still be ok to do what I have done.

Would that be ok?

Many thanks for any suggestions,

Answer 1

I would add parentheses for good measure, but otherwise you should be OK:

#define FAILURE (!(NT_SUCCESS))

This is “just in case”, to prevent bad definitions such as #define NT_SUCCESS 1+1. Of course, no sane implementation would do this, so your definition should be okay too. But it can’t hurt to be paranoid. 🙂