Question

I am using a timer to output text to textbox every 2 seconds. but it seems that it doesnt work. any idea what is wrong. here is my code:

public partial class Form1 : Form
{
    public Form1()
    {
      InitializeComponent();
    }

    public static System.Timers.Timer aTimer;

    public void BtnGenData_Click(object sender, EventArgs e)
    {
      aTimer = new System.Timers.Timer(10000);

      // Hook up the Elapsed event for the timer.
      aTimer.Elapsed += new ElapsedEventHandler(OnTimedEvent);

      // Set the Interval to 2 seconds (2000 milliseconds).
      aTimer.Interval = 2000;
      aTimer.Enabled = true;
    }

    public static void OnTimedEvent(object source, ElapsedEventArgs e)
    {
      string GenData = "Welcome";
      Form1 frm1 = new Form1();
      frm1.TboxData.AppendText(GenData.ToString());
    }
}

Actually i dont see any output coming.

Answer 1

Although this is not straightly connected with the problem you have in your code, but…

From MSDN System.Timers.Timer:

The server-based Timer is designed for use with worker threads in a
multithreaded environment.

In Windows Forms you can use System.WindowsForms.Timer:

    System.Windows.Forms.Timer timer;

    public Form1()
    {
        InitializeComponent();

        timer = new Timer();
        timer.Interval = 1000;
        timer.Tick += new EventHandler(timer_Tick);
    }

    public void BtnGenData_Click(object sender, EventArgs e)
    {
        BtnGenData.Enabled = false;
        timer.Start();
    }

    void timer_Tick(object sender, EventArgs e)
    {
        timer.Stop();
        BtnGenData.Enabled = true;

        //do what you need
    }

---

As for your code, why make the timer static? Try to use this:

 public partial class Form1 : Form
 {
    public Form1()
    {
        InitializeComponent();
    }

    public System.Timers.Timer aTimer;

    public void BtnGenData_Click(object sender, EventArgs e)
    {
        aTimer = new System.Timers.Timer(10000);
        aTimer.Elapsed += new ElapsedEventHandler(OnTimedEvent);
        aTimer.Interval = 2000;
        aTimer.Enabled = true;
    }

     public void OnTimedEvent(object source, ElapsedEventArgs e)
     {
        this.TboxData.AppendText("Welcome");
     } 
 }

Also you should take into consideration, what could happen if you pressed the button twice…