Question

I am using ASP.net MVC3 for my presentation layer and my data access and business logic are exposed through a WCF Service. Should my controllers call the WCF service or should there be a further level of abstraction such as a repository which calls the WCF service.

Repository which calls the service

public ProductController(IProductRepository productRepository)
{
      _productRepository = productRepository;
}

public ProductRepository(ProductServiceClient client)
{
      _client = client;
}

Service directly in the controllers

public ProductController(ProductServiceClient client)
{
      _client = client;
}

The repository classes do nothing apart from call the methods exposed via the service.

Answer 1

Sorry I am well confused about your question, but I am sorry if I have misunderstood. Hope my pointers will clear this up.

1. Repositories related to persistence and define a way to handle the
   infrastructure layer i.e. dealing with data (in memory repository,
   sql repository or generic one)
2. Services if you like use these repositories to perform the
   contractual operations such as getting the client in your case.
3. Services are called by clients or someone that requests services and
   service in turn calls the repository which in turn calls the data
   operations.

So you may need to change your wcf to work with repositories and let your controller call services..hope that helps