Question

I am using INSERT Trigger on that table. Once trigger is executed (it update the table if a condition is meet), that is where the problem is.

  int records = sc.ExecuteNonQuery(); // works ok if trigger does not update the record

The above code always ruturns -1 if I leave SET NOCOUNT ON; in the stored procedure itself. If I remove it, I get correct result but if trigger does update the record, then wrong result. I sometime get 10 or a different number. My Trigger looks like this

UPDATE students 
    SET status = 'Inactive'

    FROM Inserted i
        INNER JOIN students T2
            ON i.sname = T2.sname
            AND i.id <> t2.id

That means it can return more than one record (esp in test cases). Can someone tell me what is the cure? I am open to use Functions if that solves the problem or any better approach.

Thanks

Adding Insert SP

CREATE PROCEDURE sp_InsertSudent 
    -- Add the parameters for the stored procedure here
    @student_name varchar(25) = null, 
    @status varchar(20) = null,
    @renew varchar(15) = null,
    @edate datetime = null
AS
BEGIN

    --SET NOCOUNT ON;

    insert into students VALUES(@student_name,@status,@renew,@edate)


END
GO

Note: I am looking for an error because the fields are picked from Excel. if any field is in wrong format or empty, the Insert SP will produce error. I must convey that error to the user.

Adding Actual SP

So the whole problem is in the SP. If I remove it, everything works fine. Here is my actual SP

UPDATE CustomerTbl
SET [Account Status] = 'Inactive',
    [End Date] = DateAdd(day,-1,[Supplier End Date]),
    [EnrollmentStatus] = 'Waiting'
WHERE OET.[Account No] = (SELECT [Account No] FROM CustomerTbl WHERE id = @@identity)
  AND id <> @@identity

The logic is the same as above but stated differently. The ExecuteNonQuery oupts the result of this trigger than than the actual storedprocedure, so what is he cure? Can suppress its output somehow.

Answer 1

My own answer (not complete yet). According to MSDN documentation for ExecuteNonQuery

When a trigger exists on a table being inserted or updated, the return
value includes the number of rows affected by both the insert or
update operation and the number of rows affected by the trigger or
triggers.

This means I need to modify the trigger itself to accommodate the logic, or even by the fact that when trigger is called, that proves that a record was successful. That means if I get anything greater than 0, that should be assumed as success. Although not solid logic but it will work. SET COUNT ON must be commented for this.