Question

I am using search logic to filter results on company listing page. The user is able to specify any number of parameters using a variety of named URLs. For example:

/location/mexico
/sector/technology
/sector/financial/location/argentina

Results in the following respectively:

params[:location] == 'mexico'
params[:sector] == 'technology'
params[:sector] == 'financial' and params[:location] == 'argentina'

I am now trying to cleanup or ‘DRY’ my model code. Currently I have:

def self.search(params)
    ...
    if params[:location]
        results = results.location_permalink_equals params[:location] if results
        results = Company.location_permalink_equals params[:location] unless results
    end
    if params[:sector]
        results = results.location_permalink_equals params[:sector] if results
        results = Company.location_permalink_equals params[:sector] unless results
    end
    ...
end

I don’t like repeating the searchs. Any suggestions? Thanks.

---

Answer 1

This is how I would write it:

[params[:location], params[:sector]].reject(&:nil?).each do |q|
  results = (results ? results : Company).location_permalink_equals q
end

There’s plenty of other ways, just an idea. Has the benefit of making it easy to add say params[:street] or something.