Question

I am using SQL Server 2008 R2 and have run into an issue with my dynamic T-SQL query. I believe it has to do with my syntax however it runs in a new query window fine when taken out of the dynamic T-SQL context. When ran as a stored procedure I sometimes get the following error:

Column dbo.Birds.weight is invalid in the select list because it is
not contained in either an aggregate function or the GROUP BY
clause.

T-SQL code:

set @sql =
N'select FLOOR(dbo.Birds.weight * @INPUTconversion)*@INPUTinterval as ''Weight'',
COUNT(1) as ''Count''
FROM dbo.Birds
WHERE
weight >= @INPUTminwgt AND 
weight <= @INPUTmaxwgt
GROUP BY FLOOR(weight*@INPUTconversion) 
order by weight asc'


set @params =
N'@INPUTminwgt float, 
@INPUTmaxwgt float, 
@INPUTconversion float,
@INPUTinterval float';

exec sp_executesql @sql, @params,  
@INPUTminwgt = @BirdMinWeight, 
@INPUTmaxwgt = @BirdMaxWeight,
@INPUTconversion = @conversion,
@INPUTinterval = @interval;

The weights are go to the 1000 decimal place (e.g. 3.154)

@INPUTconversion = 1/interval

The query should return weights between the min and max weight parameters, grouped by the the interval (e.g. .1 intervals would be like 1.1, 1.2, 1.3, 1.4 with the counts of the total birds in that weight span)

Any help is appreciated

Answer 1

In the group by, *@INPUTintervals is missing.

It should be GROUP BY FLOOR(dbo.Birds.weight * @INPUTconversion)*@INPUTinterval

Also,you can’t use the alias weight in your where and order by, you have to use FLOOR(dbo.Birds.weight * @INPUTconversion)*@INPUTinterval or dbo.Birds.weight cause here it’s ambiguous which one you need.

set @sql =
N'select FLOOR(dbo.Birds.weight * @INPUTconversion)*@INPUTinterval as ''Weight'',
COUNT(1) as ''Count''
FROM dbo.Birds
WHERE
dbo.Birds.weight >= @INPUTminwgt AND 
dbo.Birds.weight <= @INPUTmaxwgt
GROUP BY FLOOR(weight*@INPUTconversion) *@INPUTinterval
order by FLOOR(weight*@INPUTconversion) *@INPUTinterval asc'