Question

i am using this code to insert names to table,i have a problem that after 150 +/- names the app crash with this log:

 Received memory warning. Level=1
 Received memory warning. Level=2

this is the code,did i done something wrong?

if (sqlite3_open([dataPath UTF8String], &database) == SQLITE_OK) {
    for (int i = 0 ; i < count; i++) {          
        sqlite3_stmt *insertStmt = nil;
        NSString *name = [song valueForProperty:MPMediaItemPropertyTitle];

        if(insertStmt == nil) 
        {
            NSString *statement = [NSString stringWithFormat:@"INSERT INTO Songs (name) VALUES (?)"];
            const char *insertSql = [statement UTF8String];

            if(sqlite3_prepare_v2(database, insertSql, -1, &insertStmt, NULL) != SQLITE_OK){
                NSLog(@"Error while creating insert statement.");
                insertStmt = nil;
                continue;
            }

            sqlite3_bind_text(insertStmt, 1, [name UTF8String], -1, SQLITE_TRANSIENT);


            if(SQLITE_DONE != sqlite3_step(insertStmt)){
                NSLog(@"Error while inserting data.");
                insertStmt = nil;
                continue;
            }
            else{}

            sqlite3_reset(insertStmt);
            insertStmt = nil;
        }

        [delegate IPodLibraryFinishEntity:self];
    }

    sqlite3_close(database);

}

Answer 1

Your code is not optimal. You should place all prepare methods before the loop.

if (sqlite3_open([dataPath UTF8String], &database) == SQLITE_OK) {

    sqlite3_stmt *insertStmt = nil;
    NSString *name = [song valueForProperty:MPMediaItemPropertyTitle];

    if(insertStmt == nil) {
        NSString *statement = [NSString stringWithFormat:@"INSERT INTO Songs (name) VALUES (?)"];
        const char *insertSql = [statement UTF8String];

        if(sqlite3_prepare_v2(database, insertSql, -1, &insertStmt, NULL) != SQLITE_OK){
            NSLog(@"Error while creating insert statement.");
            insertStmt = nil;
            return;
        }
    }
    for (int i = 0 ; i < count; i++) {          
        sqlite3_bind_text(insertStmt, 1, [name UTF8String], -1, SQLITE_TRANSIENT);

        if(SQLITE_DONE != sqlite3_step(insertStmt)){
            NSLog(@"Error while inserting data.");
            continue;
        }
        else{}

        sqlite3_clear_bindings(insertStmt); //release bindings
        sqlite3_reset(insertStmt);

        [delegate IPodLibraryFinishEntity:self];
    }
    sqlite3_close(database);
}