Question

I am wondering if there’s a way to write this code in a more elegant fashion:

def default_price
  if project.hourly_rate.present?
    project.hourly_rate
  elsif project.person.hourly_rate.present?
    project.person.hourly_rate    
  elsif project.person.organisation.hourly_rate.present?
    project.person.organisation.hourly_rate
  else
    user.preference.hourly_rate
  end
end

There’s a lot of repetition going on here between the conditions and the return values. Is there a better way to code this?

Thanks for any help.

Answer 1

def default_price
  [
    project.hourly_rate,
    project.person.hourly_rate,
    project.person.organisation.hourly_rate,
  ]
  .find(&:present?) ||
  user.preference.hourly_rate
end

or, to refactor a bit more:

def default_price
  [
    project,
    project.person,
    project.person.organisation,
  ]
  .find{|x| x.hourly_rate.present?}.hourly_rate ||
  user.preference.hourly_rate
end

Furthermore, if user.preference.hourly_rate is always present?, then you can further refactor:

def default_price
  [
    project,
    project.person,
    project.person.organisation,
    user.preference,
  ]
  .find{|x| x.hourly_rate.present?}.hourly_rate
end