Question

I am working in a code-base(C# 3.5), which is littered with exception handling blocks which return true/false, when inside in a function which returns ‘bool’.

catch (Exception ex) { return false; }

This is not correct practice.I am thinking of logging the exception, and have a local variable(to function) which will be initialized.And, this variable will be returned at the end of function.

What do you think?

Answer 1

The usual accepted way to handle exception is to handle them only if you can do something about it. You can of course handle a generic exception just for log puroposes but you should reraise it once you’re done.

Your application logic shouldn’t rely on exceptions. If there is absolutely no other way to do it, then at least handle concrete exceptions instead of the generic one…