Question

I am working on an application that uses Crystal Reports for the reporting. It opens a given report in a ReportDocument object, does what it needs to do and then closes the report.

using (var report = OpenReport(reportSourceInfo))
{
    // Do stuff with the report
    report.Close();
}

The OpenReport method does some validation of the source file and returns an open ReportDocument object.

Testing has shown that this code does what it’s meant to do and appears to have no issues. The problem I’m really after advice on is when I do a code analysis (CA) build of the reporting project, I get the following CA message:

CA2202 : Microsoft.Usage : Object ‘report’ can be disposed more than once in method ‘CrystalReportingProvider.ReportExecute(ReportSourceInformation)’. To avoid generating a System.ObjectDisposedException you should not call Dispose more than one time on an object.

Now obviously I can change the code around so I don’t get this CA warning, but my question is should I?

Does the Crystal Reports ReportDocument.Close() method do everything to handle resource cleanup properly? The message seems to indicate that the Close method calls the Dispose method, but that just doesn’t seem right.

Any advice would be appreciated.

Answer 1

Well, according to this, “Close() … release[s] the memory that is used by the report.” That would indicate that Close() calls Dispose(), so it would be redundant to have both a using statement and Close().