Question

I am working on an exercise in C++ and I am trying to understand how to remove an element from a list and shift the rest to the left. I wonder if there is a neat solution. Here is my version, it seems to do the job, but I have a feeling there is a better way:

Account AccountList::remove(int i){
if(i>=0 && i<size()) {
    for (int n = i; n < size(); n++) {
        if(i+1!=size()) {
            aList[n]=aList[n+1];
        }
    }
    sz--;
    return aList[i];
} else {
    return Account();
}
}

Answer 1

You have two issues in this.

1. You are not returning the removed element, instead overwriting it with the next element and returning that one. I don’t think this is your intention.
2. Your loop range is not right. With this loop, you will go past the array bounds with the index n+1 when n = size() – 1

The corrected one is given below.

Account AccountList::remove(int i)
{
  if(i>=0 && i<size()) 
  {
    Account a = aList[i]
    for (int n = i; n < size() - 1; n++) 
    {
        if(i+1!=size()) 
        {
            aList[n]=aList[n+1];
        }
    }
    sz--;
    return a;
  } else 
  {
    return Account();
  }
}