Question

I am working on this very simple method I know I am very close to finish it, but I am missing a detail. I appreciate any help. Thank you.

/**
  Gets the first letter in this string.
  @return the FIRST LETTER, or "" if there are no letters.
  add1=AD3F add2=EF4G result=32SFB  (BUT THESE ARE RANDOM ONLY INTS AND CHARS)
*/
public String firstLetter()
{
    String line = add1+add2+result;

    for(int i=0; i<line.length(); i++){
    char ch=new Character(line.charAt(i));
    if(Character.isLetter(ch)){
        System.out.println("This is the first letter"+ch);
        return ch;
    }
    else
        System.out.println("No it is not a character: "+ch);
    return "";
    }

Answer 1

You need to move the else code outside the loop so that it is only executed when you have tested all of the characters:

public class FirstLetter
{
    public static void main(String[] args)
    {
        System.out.println(firstLetter());
    }

    public static String firstLetter()
    {
        String line = "AD3F" + "EF4G" + "32SFB";

        for (int i = 0; i < line.length(); i++)
        {
            char ch = line.charAt(i);
            if (Character.isLetter(ch))
            {
                System.out.println("This is the first letter: " + ch);
                return Character.toString(ch);
            }

        }
        System.out.println("No character found");
        return "";
    }
}

This kind of problem is more obvious when you format the code clearly.

I have kept the return type as String as per your original, but see also Jon Skeet’s comments about changing that to char.