Question

I believe in learning along the process and the following code segment is not very clear to me. I know that an alloc statement would increase the retain count however there are certain aspects of iOS development that are still very confusing to me.

Why do I need a : [jokesArray retain]; in the following code segment?

I have a jokesArray = [[NSArray alloc]init]; and from what I have read is enough to retain?

Can someone please explain in an easy to understand manner why that retain statement is needed? (Else the app crashes with a EXC_Bad_Access.

I have had some kind people try to explain but it has not worked. Any help will be greatly appreciated.

#import "JokesViewController.h"


@implementation JokesViewController

- (id)initWithStyle:(UITableViewStyle)style
{
    self = [super initWithStyle:style];
    if (self) {
        // Custom initialization
    }
    return self;
}

- (void)dealloc
{
    [super dealloc];
}

- (void)didReceiveMemoryWarning
{
    // Releases the view if it doesn't have a superview.
    [super didReceiveMemoryWarning];

    // Release any cached data, images, etc that aren't in use.
}

#pragma mark - View lifecycle

- (void)viewDidLoad
{

    [super viewDidLoad];

    jokesArray = [[NSArray alloc]init];

    [self getJokes];
}

- (void)viewDidUnload
{
    [super viewDidUnload];
    [jokesArray release];

}


- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
{
    // Return YES for supported orientations
    return (interfaceOrientation == UIInterfaceOrientationPortrait);
}

#pragma mark - Table view data source

- (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView
{
    // Return the number of sections.
    return 1;
}

- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
{

    // Return the number of rows in the section.
    return [jokesArray count];
}

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    static NSString *CellIdentifier = @"Cell";

    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
    if (cell == nil) {
        cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier] autorelease];
    }





[[cell textLabel]setText:[[jokesArray objectAtIndex:0]objectForKey:@"text"]];    

 //   [[cell textLabel]setText:@"ok"];   

    return cell;
}

#pragma mark - Table view delegate

- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
{
    // Navigation logic may go here. Create and push another view controller.
}


#pragma mark - Custom Functions

-(void) getJokes
{
    NSURL *url = [NSURL URLWithString:@"someurl"];
    __block ASIHTTPRequest *request = [ASIHTTPRequest requestWithURL:url];
    [request setCompletionBlock:^{
        // Use when fetching text data
        NSString *responseString = [request responseString];

        NSDictionary *resultsDictionary = [responseString objectFromJSONString];
        jokesArray = [resultsDictionary allValues];

        [jokesArray retain];  //WHY DO I NEED THIS?


        [self.tableView reloadData];

        NSLog(@"%@", [jokesArray description]);

        // Use when fetching binary data
  //      NSData *responseData = [request responseData];
    }];
    [request setFailedBlock:^{
        NSError *error = [request error];

    }];
    [request startAsynchronous];
}

@end

Answer 1

You are leaking your previous NSArray allocation because in this part of the code:

 NSDictionary *resultsDictionary = [responseString objectFromJSONString];
    jokesArray = [resultsDictionary allValues];

    [jokesArray retain];

You are creating an NSDictionary and replacing whatever jokesArray was pointing to point to the data from NSDictionary that you just created.
Also the data returned by NSDictionary was created using a convenience initialization method which means it will get released after a while thus the reason why you need to retain.

Since you are modifying the jokesArray variable directly the previously allocated NSArray doesn’t get released when you replace it with the new object.