Question

I bet this task has a shorter and more nice way to be written?

/// <summary>
/// Consumption between two parameters
/// </summary>
public double Consumed(double val1, double val2)
{
    double currentValue = 0;

    // Don't calculate backward
    if (val1 < val2)
    {
        currentValue = val1;
        val2 = val1;
        val2 = currentValue;
    }
    currentValue = (val1 - val2);
    return currentValue;
}

One way would just be invert result if negative.
What would you say state as “Best practice”?
Thank’s in advanced,

Answer 1

You’re calculating the absolute value of the difference between the two input values:

public double Consumed(double val1, double val2)
{
    return Math.Abs(val1 - val2);
}