Question

I cannot figure this problem out. Everything in the program works the way i want it to except after i use the ‘o’ open account option, ‘w’ withdrawal accout options.. etc that after completion, repeats the loop as desired, but returns the else line “Command was not recognized; please try again.” and then reprints the menu. If i use the ‘s’ command it works fine. i removed the “balance = input.nextDouble();” line and it works correctly, but i can’t figure out why it returns the else statement and reprints.

import java.util.Scanner;
import java.text.*;

public class Bank
{
     public static void main( String[] args )
     {
         Scanner input = new Scanner( System.in );
            String eol = System.getProperty("line.separator");

            DecimalFormat df = new DecimalFormat("0.00");

            int numAccounts = 1;
            String number = "None Selected";
            String userInput;
            double balance = 0;
            double amount = 0;
            int i = 0;
            int j;

            BankAccount[] accounts = new BankAccount [100];

            accounts[0] = new BankAccount (number, balance); 

            String BBalance = df.format(accounts[i].getBalance());

            while (1 < 2){

                if (numAccounts == accounts.length){
                    BankAccount[] tempArray = new BankAccount[accounts.length * 2];
                            for (int k = 0; k < accounts.length; k++){
                                tempArray[k] = accounts[k];
                                }
                                accounts = tempArray;

                }
                try{
                    System.out.print ( eol +
                                    "-----------------------------------------------------" + eol +
                                    "|Commands: o - Open account        c - Close account|" + eol +
                                    "|          d - Deposit             w - Withdraw     |" + eol +
                                    "|          s - Select account      q - Quit         |" + eol +
                                    "-----------------------------------------------------" + eol +
                                    "Current account: " + accounts[i].getNumber() + "       Balance: $" + df.format(accounts[i].getBalance()) +
                                    eol );
                    }
                catch(java.lang.Throwable t) {
                System.out.println("Account number was not found");
                }

                userInput = input.nextLine().trim().toLowerCase();


                if (userInput.substring(0).equals("o")) {
                    System.out.print("Enter Account Number: ");
                    number = input.nextLine();
                    System.out.print("Enter Initial Balance: ");
                    balance = input.nextDouble();

                    accounts[numAccounts++] = new BankAccount (number, balance); 
                    i = numAccounts - 1;
                    continue;
                }
                else if (userInput.substring(0).equals("d")) {
                    System.out.print("Enter Account Number: ");
                    number = input.nextLine();
                        for (i =0; i < numAccounts; i++)
                            if (accounts[i].getNumber().equals(number))
                                break;


                    System.out.print("Enter Amount To Deposit: ");
                    amount = input.nextDouble();

                    accounts[i].deposit(amount);
                    continue;
                }
                else if (userInput.substring(0).equals("s")) {
                    System.out.print("Enter Account Number: ");
                    number = input.nextLine();
                        for (i =0; i < numAccounts; i++){
                            if (accounts[i].getNumber().equals(number)){
                                break;
                            }

                        }
                        if (i != numAccounts){
                            System.out.print("Account number was not found");
                        }
                        continue;
                }
                else if (userInput.substring(0).equals("c")) {
                    System.out.print("Enter Account Number: ");
                    number = input.nextLine();
                        for (i =0; i < numAccounts; i++)
                            if (accounts[i].getNumber().equals(number))
                                break;

                    accounts[i] = accounts[--numAccounts];
                    continue;
                }
                else if (userInput.substring(0).equals("w")) {
                    System.out.print("Enter Account Number: ");
                    number = input.nextLine();
                        for (i =0; i < numAccounts; i++)
                            if (accounts[i].getNumber().equals(number))
                                break;


                    System.out.print("Enter Amount To Withdraw: ");
                    amount = input.nextDouble();

                    accounts[i].withdraw(amount);
                    continue;
                }
                else if (userInput.substring(0).equals("q")) {

                    System.exit(0);
                }
                else{
                    System.out.println("Command was not recognized; please try again.");
                    continue;
                }

            }

            //System.out.print(userInput);
            //System.out.print(accounts[0]);

     }
}

Here’s the BankAccount class:

public class BankAccount {

    String number = "123-456";
    double balance = 1.00; 

    public BankAccount(String accountNumber, double initialBalance){
        number = accountNumber;
        balance = initialBalance;
    }
    public void deposit (double amount){
        balance += amount;
    }
    public void withdraw (double amount){
        balance -= amount;
    }
    public String getNumber(){
        return number;
    }
    public double getBalance(){
        return balance;
    }

    BankAccount[] accounts = new BankAccount [100];

}

Answer 1

You’re not skipping past the end of the lines when you’re reading in the second numbers in the commands that require one.

Adding an input.nextLine() to those is one quick way around it (non I/O lines redacted).

    // etc.
} else if (userInput.substring(0).equals("d")) {
    System.out.print("Enter Account Number: ");
    number = input.nextLine();

    System.out.print("Enter Amount To Deposit: ");
    amount = input.nextDouble();
    input.nextLine();

    continue;
} // etc.