Question

I created a program which will parse the firstName, middleName and lastName. Here is the program and output. This program can definitely be improved and need some input on reducing my cumbersome ugly code and replace it with a better one. Any suggestions or example ?

public class Test {

  public static void main(String[] args) {

    String fullName = "John King IV. Cena";
    String[] tokens = fullName.split(" ");
    String firstName = "";
    String middleName = "";
    String lastName = "";
    if(tokens.length > 0) {
        firstName = tokens[0];
        middleName = tokens.length > 2 ? getMiddleName(tokens) : "";
        lastName = tokens[tokens.length -1];
    }
    System.out.println(firstName);
    System.out.println(middleName);
    System.out.println(lastName);
  }

  public static String getMiddleName(String[] middleName){
      StringBuilder builder = new StringBuilder();
      for (int i = 1; i < middleName.length-1; i++) {
          builder.append(middleName[i] + " ");
      }

      return builder.toString();
  }
}

John
King IV.
Cena

Answer 1

This code does the same, but doesn’t keep a trailing space in the middle name. This is one of several possible cleaner implementations.

public class Test {

    public static void main(String[] args) {

        String name = "John King IV. Cena";

        int start = name.indexOf(' ');
        int end = name.lastIndexOf(' ');

        String firstName = "";
        String middleName = "";
        String lastName = "";

        if (start >= 0) {
            firstName = name.substring(0, start);
            if (end > start)
                middleName = name.substring(start + 1, end);
            lastName = name.substring(end + 1, name.length());
        }    

        System.out.println(firstName);
        System.out.println(middleName);
        System.out.println(lastName);
    }
}

As the guys said, next time go directly to https://codereview.stackexchange.com/