Question

I do a Action on Middle ware and if its success i get the Value as

String result = ["RESULT","DELETE","OK"]

And in Case if the Operation is Failed i get the resposne as

String result = ["RESULT","DELETE","ERROR"]

I need to know if the Operation is success Or Fail so for this i have done this

public class Test {

    public static void main(String args[]) {

        String result = "[\"RESULT\",\"DELETE\",\"ERROR\"]";

        if (!result.contains("ERROR")) {
            System.out.println("success");
        } else {
            System.out.println("Failed");
        }

    }

This is working fine , but not sure if this has any negative impact / or in cases the code may Fail .

Please suggest if there is a better approach .

Answer 1

Your code can fail if, for instance, you get a success message containing ERROR (not likely, but can happen).

You should use a library to parse the result into a List/Array, look here on StackOverflow for a ton of solutions for parsing Json Strings to Objects in Java (Jackson is a library to do this, for instance).

You should also validate against a pre-set number of hypothesis, for instance, creating an enum for the possible result types, and checking if it’s one of them.