Question

I don’t know why this is erroring, but I’m just trying to add something “akin” to endl so that I can throw what’s in an ostringstream to our debugger. I have the following:

class debug_stream_info
{
public:
    debug_stream_info(int errorLine, char *errorFile, int level)
        :m_errorLine(errorLine), m_errorFile(errorFile), m_logLevel(level)
    {
    }

    friend std::basic_ostringstream<char>& operator<<(std::basic_ostringstream<char>& os, debug_stream_info& debug_info);

private:
    int m_errorLine;
    std::string m_errorFile;
    int m_logLevel;

};

std::basic_ostringstream<char>& operator<<(std::basic_ostringstream<char>& os, debug_stream_info& debug_info)
{
    // Write the stream's contents to cpu_debug
    // Deleted custom logging function.  No errors here though

    // Clear the stream for re-use.
    os.str("");
    os.seekp(0);

    return os;
}

int main(int argc, char** argv)
{
    std::ostringstream myout;
    myout << "hey there" << " and some more " << "Numbers!!: " << 435 << 54.2 << " that's good for numbers" << debug_stream_info(__LINE__, __FILE__, LOG_LEVEL);

    return 0;
}

The error I’m getting is: error C2679: binary '<<' : no operator found which takes a right-hand operand of type 'debug_stream_info' (or there is no acceptable conversion) for the line in main. This is on VS2008.

I’m including sstream, iostream, etc, and have the namespaces set up right. I’m getting no other errors. I even tried replacing all occurrances of basic_ostream with just ostringstream and there was no difference (I’ll be having a w_char version later, but I wanted the simple case to work first). I made the object on the line above and then passed a fully-constructed object on the line, and the error was exactly the same. I’ve changed the signature of the second argument to and from const with no change as well.

Any ideas on what I’m doing wrong here?

Edit: since EVERY response seems to want to put it there, I can NOT use std::ostream because I want this to work ONLY for std::ostringstream (and std::basic_ostringstream) and not for any type of output stream. Besides, the function wouldn’t compile with ostream anyways, since I’m using the os.str() method, which isn’t in ostream, only the sub-classes.

Answer 1

The real problem with your code is that you’ve overloaded std::ostringstream rather than std::ostream. So your code would work if you write this:

debug_stream_info info(/** blah blah**/);

std::ostringstream oss;
oss << info ; //OK

However this will not work:

oss << 1 << info; //ERROR

This is compilation error because the expression oss<<1 returns an object of type std::ostream& which doesn’t have overload which takes debug_stream_info as second argument. That means if you use cast as:

static_cast<std::ostringstream&>(oss << 1) << info; //OK

then that should work again.

So the solution is to overload std::ostream, instead of std::basic_ostringstream.

Also, the second parameter should be const & . This is also a problem with your code.

So write this:

std::ostream& operator<<(std::ostream&, debug_stream_info const &);
                                                        //^^^^^^^ note this

The second parameter should be const & so that you could write temporary objects to the stream.