Home/ Questions/Q 172693
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-11T13:12:40+00:00

I get Incorrect syntax errors on every nested IF and ELSE statements in the

  • 0

I get ‘Incorrect syntax’ errors on every nested IF and ELSE statements in the following code… what’s wrong ?

ALTER PROCEDURE [WTFAULT].[usp_WTFault_GetPartFaultStatus] ( @linxPartId int = -1, @faultStatus varchar(10) output ) AS BEGIN      DECLARE @NbFaultsInParts int,             @NbPartsReturned int      SET @NbPartsReturned = (SELECT COUNT(*) FROM WTFAULT.PART, WTFAULT.FAULT WHERE WTFAULT.PART.FAULT_COID = WTFAULT.FAULT.COID                                  AND WTFAULT.PART.LINX_PARTID = @linxPartId AND WTFAULT.FAULT.MATURITY = 'ALLOCATED')      IF @NbPartsReturned > 0 BEGIN             SET @faultStatus = 'ALLOCATED'     END     ELSE BEGIN             SET @NbPartsReturned = (SELECT COUNT(*) FROM WTFAULT.PART, WTFAULT.FAULT WHERE WTFAULT.PART.FAULT_COID = WTFAULT.FAULT.COID                                          AND WTFAULT.PART.LINX_PARTID = @linxPartId AND WTFAULT.FAULT.MATURITY = 'DRAFT')              IF @NbPartsReturned > 0 BEGIN                     SET @faultStatus = 'DRAFT'             END             ELSE BEGIN                 SET @NbPartsReturned = (SELECT COUNT(*) FROM WTFAULT.PART, WTFAULT.FAULT WHERE WTFAULT.PART.FAULT_COID = WTFAULT.FAULT.COID                                              AND WTFAULT.PART.LINX_PARTID = @linxPartId AND WTFAULT.FAULT.MATURITY = 'CLOSED')                 IF @NbPartsReturned > 0 BEGIN                         SET @faultStatus = 'CLOSED'                 END                 ELSE BEGIN                         SET @faultStatus = ''                 END             END         END END GO
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Try this different method:

    ALTER PROCEDURE [WTFAULT].[usp_WTFault_GetPartFaultStatus](@linxPartId int = -1, @faultStatus varchar(10) output) AS     SELECT COUNT(*) as MaturityCount,WTFAULT.FAULT.MATURITY  INTO #Temp FROM WTFAULT.PART JOIN WTFAULT.FAULT      ON WTFAULT.PART.FAULT_COID = WTFAULT.FAULT.COID  WHERE TFAULT.PART.LINX_PARTID = @linxPartId  GROUP BY WTFAULT.FAULT.MATURITY  If (select MaturityCount from #temp where WTFAULT.FAULT.MATURITY = 'ALLOCATED') >0     BEGIN         SET @faultStatus = 'ALLOCATED'     END ELSE IF (select MaturityCount from #temp where WTFAULT.FAULT.MATURITY = 'DRAFT') >0     BEGIN         SET @faultStatus = 'DRAFT'     END ELSE IF (select MaturityCount from #temp where WTFAULT.FAULT.MATURITY = 'CLOSED') >0     BEGIN         SET @faultStatus = 'CLOSED'       END ELSE      BEGIN                                                 SET @faultStatus = ''                             END

    I also changed your query to use ANSI standard joins. You should use them too from now on. They are clearer, easier to maintain and will not give wrong results when you use outer joins and are far less likely to result in a cross join by accident.

    • 0