Question

I get NPE in JSF validator and I cannot find what cause this problem:

// Validate Datacenter Name
    public void validateDatacenterName(FacesContext context, UIComponent component, Object value) throws ValidatorException, SQLException
    {
        // Original value
        Object modelValue = ((UIInput) component).getValue();

        String oriDCName = modelValue.toString();

        String s; // New inserted value

        if (value != null && !(s = value.toString().trim()).isEmpty())
        {

            if (s.length() > 18)
            {
                throw new ValidatorException(new FacesMessage(FacesMessage.SEVERITY_ERROR,
                        "  Value is too long! (18 digits max)", null));
            }

            if (ds == null)
            {
                throw new SQLException("Can't get data source");
            }

            Connection conn = null;
            PreparedStatement ps = null;
            ResultSet rs;
            String resDCName = null;
            try
            {
                conn = ds.getConnection();
                // if componentsstatsid <> edited componentstatsid in jsf -> throw validator exception
                ps = conn.prepareStatement("SELECT NAME from COMPONENTSTATS where NAME = ?");
                ps.setString(1, s);
                rs = ps.executeQuery();

                while (rs.next())
                {
                    resDCName = rs.getString(1);
                }

                if (resDCName != null && (!resDCName.equals(oriDCName) ))
                {
                    throw new ValidatorException(new FacesMessage(FacesMessage.SEVERITY_ERROR,
                            "  '" + s + "' is already in use!", null));
                }

            }
            catch (SQLException x)
            {
                throw new ValidatorException(new FacesMessage(FacesMessage.SEVERITY_ERROR,
                        "  SQL error!", null));
            }
            finally
            {
                if (ps != null)
                {
                    ps.close();
                }
                if (conn != null)
                {
                    conn.close();
                }
            }
        }
        else
        {
            throw new ValidatorException(new FacesMessage(FacesMessage.SEVERITY_ERROR,
                  "  This field cannot be empty!", null));
        }

    }

When I enter new value which is unique I get NPE. When I enter value which is already found into the DB table I get ...is already in use!.

The problem is somewhere here if (resDCName != null && (!resDCName.equals(oriDCName) )) but I cannot solve it. Any idea how to fix this?

Answer 1

change your logic like below code. I am assuming you want resDCname should not be equals to origDCName.

while (rs.next())
{

    resDCName = rs.getString(1);
 if (resDCName != null && resDCName.equals(oriDCName))
    {
       throw new ValidatorException(new FacesMessage(FacesMessage.SEVERITY_ERROR,
                           "  '" + s + "' is already in use!", null));
     }
   }