Question

i get this error line on this php file . can someone locate where is the error ?

————-You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ” at line 1———-

i have this page for votes to users but if i vote in one user this vote goes to all users . how can i make this code when voting this vote goes only to its user .
—

 // Connects to your Database 
 mysql_connect("localhost", "dbusername", "dbpassword") or die(mysql_error()); 
 mysql_select_db("mydatabase") or die(mysql_error()); 

//We only run this code if the user has just clicked a voting link
 if ( $mode=="vote") 
 { 

 //If the user has already voted on the particular thing, we do not allow them to vote     again    
    //$cookie = "Mysite$id"; 
if(isset($_COOKIE[$cookie])) 
    { 
    Echo "Sorry You have already ranked that site <p>"; 
    } 

 //Otherwise, we set a cooking telling us they have now voted 
else 
    { 
    $month = 2592000 + time(); 
    setcookie('Mysite'.$id, 'Voted', $month); 

     //Then we update the voting information by adding 1 to the total votes     and adding their vote (1,2,3,etc) to the total rating 

 mysql_query ("UPDATE userads SET total = total+$voted, votes = votes+1 WHERE id =     $id"); 

    } 
 } 
  if ( $mode2=="vote") 
 { 

 //If the user has already voted on the particular thing, we do not allow them to vote     again    
    //$cookie = "Mysite$id"; 
if(isset($_COOKIE[$cookie])) 
    { 
    Echo "Sorry You have already ranked that site <p>"; 
    } 

 //Otherwise, we set a cooking telling us they have now voted 
else 
    { 
    $month = 2592000 + time(); 
    setcookie('Mysite'.$id, 'Voted', $month); 

     //Then we update the voting information by adding 1 to the total votes     and adding their vote (1,2,3,etc) to the total rating 

 mysql_query ("UPDATE userads SET total = total+$voted, nvotes = nvotes+1 WHERE id =     $id"); 

    } 
 }  

 //Puts SQL Data into an array
 $data = mysql_query("SELECT * FROM userads WHERE id = $id ") or die(mysql_error()); 

 //Now we loop through all the data 
 while($ratings = mysql_fetch_array( $data )) 

?>
<link href="style.css" type="text/css" rel="stylesheet" />
 { 
<?php
echo '<div id="voting_14" class="voting voting_template_votess-up-down">';
echo "<strong class='positive_votes'>";
$current = $ratings[votes];
echo "<span>+" . round($current,0) . "</span>";
echo "<a href=".$_SERVER['PHP_SELF']."?mode=vote&voted=1&id=".$ratings[id].">       <input class='vote_positive' type='submit'></a>";
echo '</strong>';

echo "<strong class='negative_votes'>";
$current2 = $ratings[nvotes]; 
echo "<a href=".$_SERVER['PHP_SELF']."?mode2=vote&voted=2&id=".$ratings[id].">      <input class='vote_negative' type='submit'></a>";
echo "<span>-". round($current2,0) ."</span>";
echo '</strong>';

echo '</div>';

 } 
 ---the end 

i have sql table userads with : id , name , username , total, votes , nvotes.

Answer 1

Correct your code to following,

setcookie('Mysite'.$id, 'Voted', $month); // ERROR 1

and

 while($ratings = mysql_fetch_array( $data )) 
{  // ERROR 2
?>