Question

I got a method in which server-client communication is done “onClick” therefor i create a anonymous OnClickListener, and I want to publish a toast if the communication was successfull or not.
To do this I need the Acitivity in which context to publish the toast, and as I externalized the method, it must be given as a “this” argument to the Activity. But as I am inside an anonymous inner class I cannot access the this pointer of the Acitivity, and even though I stored it in a local final variable

private final Activity activity = this; 

    @Override
    public void onCreate(Bundle savedInstanceState) {
            lastResult = null;
            super.onCreate(savedInstanceState);
            setLayout(R.layout.main);
            qrscan = (Button) findViewById(R.id.qrcodescan);
            qrscan.setOnClickListener( new View.OnClickListener() {
                                               public void onClick(View view) {
                                                   initiateScan(activity);
                                               }
                                       }
                                     );
    }


private AlertDialog initiateSend(Activity activity) {

        if(lastResult != null) {
        String[] arr = lastResult.content.split("/");
        AlertDialog.Builder downloadDialog = new AlertDialog.Builder(activity);
        String[] args = Util.filterString(arr,this);
        downloadDialog.setTitle(args[0]);
        downloadDialog.setMessage("Auftragsnummer:" + args[1]);
        downloadDialog.setPositiveButton(getString(R.string.ja), new DialogInterface.OnClickListener() {
                                                              public void onClick(DialogInterface dialogInterface, int i) { 
                                                                        try {
                                                                             String send = lastResult.content;
                                                                             send += "/uid/" + R.id.username + "/cid/" + R.id.password;
                                                                             String result = Util.send(send);

                                                                             //toaster(send);


                                                                             Util.toaster(result,activity);

                                                                             if(!(result.equals("OK") || result.equals("ok") || result.equals("Ok")))
                                                                                 throw new Exception("Bad Server Answer");



                                                                             Util.toaster("Communication erfolgreich",activity);
                                                                        } catch(Exception ex) {
                                                                             ex.printStackTrace();
                                                                             Util.toaster("Communication nicht erfolgreich",activity);
                                                                        }
                                                            }
                                                        });
        downloadDialog.setNegativeButton(getString(R.string.nein), new DialogInterface.OnClickListener() {
                                                                        public void onClick(DialogInterface arg0, int arg1) {} 
                                                                    });
        return downloadDialog.show();
        }
        return null;
    }

Any clue what i messed up?

Answer 1

declare variable before onCreate() like this

public class HelloAndroid extends Activity {
Activity activity = this; // declare here

    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
    }
}

EDITED

Activity mainActivity; 

    @Override
    public void onCreate(Bundle savedInstanceState) {

            super.onCreate(savedInstanceState);

            setLayout(R.layout.main);
mainActivity = this;
lastResult = null;
            qrscan = (Button) findViewById(R.id.qrcodescan);
            qrscan.setOnClickListener( new View.OnClickListener() {
                                               public void onClick(View view) {
                                                   initiateScan(mainActivity);
                                               }
                                       }
                                     );
    }


private AlertDialog initiateSend(final Activity activity) {

        if(lastResult != null) {
        String[] arr = lastResult.content.split("/");
        AlertDialog.Builder downloadDialog = new AlertDialog.Builder(activity);
        String[] args = Util.filterString(arr,this);
        downloadDialog.setTitle(args[0]);
        downloadDialog.setMessage("Auftragsnummer:" + args[1]);
        downloadDialog.setPositiveButton(getString(R.string.ja), new DialogInterface.OnClickListener() {
                                                              public void onClick(DialogInterface dialogInterface, int i) { 
                                                                        try {
                                                                             String send = lastResult.content;
                                                                             send += "/uid/" + R.id.username + "/cid/" + R.id.password;
                                                                             String result = Util.send(send);

                                                                             //toaster(send);


                                                                             Util.toaster(result,activity);

                                                                             if(!(result.equals("OK") || result.equals("ok") || result.equals("Ok")))
                                                                                 throw new Exception("Bad Server Answer");



                                                                             Util.toaster("Communication erfolgreich",activity);
                                                                        } catch(Exception ex) {
                                                                             ex.printStackTrace();
                                                                             Util.toaster("Communication nicht erfolgreich",activity);
                                                                        }
                                                            }
                                                        });
        downloadDialog.setNegativeButton(getString(R.string.nein), new DialogInterface.OnClickListener() {
                                                                        public void onClick(DialogInterface arg0, int arg1) {} 
                                                                    });
        return downloadDialog.show();
        }
        return null;
    }