Question

I got some html code

<?php 
    if($loggedIn){
       echo "<div id='navigation'>
            <ul>
                <li>
                    <a href='javascript:toggleLayer('video');'>Global</a>
                </li>
                <li>
                    <a href='javascript:toggleLayer('info');'>About</a>
                </li>
                <li>
                    <a href='javascript:toggleLayer('register_main');'>Join!</a>
                </li>
            </ul>
        </div>"};

But when I click on the url’s on the website, they happen not to execute the javascript code.
after inspectiong one of the elements I found out that

<a video');'="" href="javascript:toggleLayer(">Global</a>

is the code generated, which is wrong ofcourse.

My only clue would be that it should be

     <a href="javascript:toggleLayer('video');">Global</a>

Though i have no clue how to fix that inside the echo, because it has to be in between the if-statement

Thanks in advance!

Answer 1

Replace:

<?php if($loggedIn){
   echo "<div id='navigation'>
        <ul>
            <li>
                <a href='javascript:toggleLayer('video');'>Global</a>
            </li>
            <li>
                <a href='javascript:toggleLayer('info');'>About</a>
            </li>
            <li>
                <a href='javascript:toggleLayer('register_main');'>Join!</a>
            </li>
        </ul>
    </div>"}; ?>

with:

<?php if($loggedIn){ ?>
    <div id="navigation">
        <ul>
            <li>
                <a href="javascript:toggleLayer('video');">Global</a>
            </li>
            <li>
                <a href="javascript:toggleLayer('info');">About</a>
            </li>
            <li>
                <a href="javascript:toggleLayer('register_main');">Join!</a>
            </li>
        </ul>
    </div>
<?php } ?>

When using quotes inside of strings " I said "Hello" ". You need to escape the matching surrounding quotes like: " I said \"Hello\" ".