Question

I got the following snippet

Class Artist < ActiveRecord
   attr_accessible :solo #boolean

  def change_solo!
    if self.solo == false
     self.solo = true
    else
     self.solo = false
    end
   self.save
  end

end

Is there a better way to write that? Thanks in advance
cheers tabaluga

Answer 1

Aha! I can shrink it even further, heh:

def change_solo!
  update_attribute :solo, !solo
end

This does the save automatically.

But it wouldn’t be complete without tests:

def test_change_solo_true_to_false
  Artist.create :solo => true
  assert Artist.change_solo!
  assert !Artist.solo?
end

def test_change_solo_false_to_true
  Artist.create :solo => false
  assert Artist.change_solo!
  assert Artist.solo?
end

By the way, above I use the convention that any boolean attribute in ActiveRecord can have a question mark at the end to make it more self-explanatory.