Home/ Questions/Q 8891031
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-14T22:38:09+00:00

I had a PHP page where I was echoing out all the HTML. After

  • 0

I had a PHP page where I was echoing out all the HTML. After being advised that is poor practice, and that I should write out the HTML and only switch to PHP when I need it, I am trying to rewrite my form to adhere to that.

I’ve tried the following, however the $row array which contains the results of my SQL query are not being called correctly, 

<?php while($row = $sth->fetch()){ ?>
<p>
<input type = "hidden" name ="id" value="<?php $row["id"] ?>"/>';
<p>
<input type = "text" name ="firstName" size ="30" value=" <?php $row["firstName"]?>"/>';</p>
<p>
<input type = "text" name ="lastName" size ="30" value="<?php $row["lastName"]?>"/>';
</p>";
<input type="submit" value="Update" />';
<?php } ?>

From my understanding as long as the start and end brackets are still in the right order, the above code should work, however it does not.

What am I doing wrong?

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team
    <?php while($row = $sth->fetch()){ ?>
<p>
<input type = "hidden" name ="id" value="<?php echo $row["id"]; ?>"/>';
<p>
<input type = "text" name ="firstName" size ="30" value=" <?php echo $row["firstName"]; ?>"/>';</p>
<p>
<input type = "text" name ="lastName" size ="30" value="<?php echo $row["lastName"]; ?>"/>';
</p>";
<input type="submit" value="Update" />';
<?php } ?>

    You forgot to put echo, without echo it won’t print anything.

    You have another option, which is:

    <?php while($row = $sth->fetch()){
echo<<<HTML
<p>
<input type = "hidden" name ="id" value="{$row['id']}"/>';
<p>
<input type = "text" name ="firstName" size ="30" value=" {$row['firstName']}"/>';</p>
<p>
<input type = "text" name ="lastName" size ="30" value="{$row['lastName']}"/>';
</p>";
<input type="submit" value="Update" />';
HTML;
} ?>
    • 0