Question

I have 2 functions declared makeAjaxCall and editOrderDetails

editOrderDetails executes makeAjaxCall to go and get a json object with the results of the call.

    function editOrderDetails()
{
    makeAjaxCall(
        baseurl+'/orderoutbound/editorderdetails',
        'orderID='+orderID+'&customerReference='+("#orderReference").val()+'&email='+$("#emailAddress").val(),
        function(data){
            if(data.success)
            {
                $("#editOrderDetailsErrorDiv").html(successDiv(data.generalMessage));
                $(".customerReferenceSpan").html(data.order.customerReference);
                $(".emailSpan").html(data.order.emailAddress);

            }else{
                $("#editOrderDetailsErrorDiv").html(errorDiv(data.generalMessage));
                $("#emailAddressErrorDiv").html(data.errors.emailAddress);                  
            }
        }, 
        function(data) {
            $("#editOrderDetailsErrorDiv").html(errorDiv("There was an error.."));
        }
    );
}

now i’m using a jquery dialog to work with

$("#editOrderDetailsDialog").dialog('destroy').dialog({
            autoOpen: false,
            title: 'Edit Order Details',
            closeOnEscape: true,
            width: 500,
            height: 300,
            buttons:{ 
                "Save": function() { editOrderDetails(); },
                "Cancel": function() { $(this).dialog("close"); }
            }
        });

as my save call back function i’m trying to set my editOrderDetails function.

This however doesnt work and i’m guessing it has something to do with the scopeing.

i have tried declaring var editOrderDetails = function(){}; outside of any and all jquery doc ready functions

i have also tried window.editOrderDetails()
also instead of making a function wrapping the function call

i have tried putting the function into a variable var editOrderDetails = function(){};
then “save” : editOrderDetails

i’m at a loss. any ideas would be appreciated ?

PS yes the dialog works correctly. if i place an alert in the callback function it executes when i click save.

<script type="text/javascript">
<!--

var orderID = '<?= $this->orderID; ?>';
var customerID = '<?= $this->customerID; ?>';

//################  PAGE FUNCTIONS ################

//MAKE AN AJAX CALL
    function makeAjaxCall(ajaxUrl, data, functionSuccess, functionFailure){
   $.ajax(
   {
       type: "GET",
       url: ajaxUrl,
       contentType: "application/json; charset=utf-8",
       data: data,
       dataType: "json",
       success: functionSuccess,
       error: functionFailure
   });
}
//END MAKE AN AJAX CALL

//EDIT ORDER DETAILS
function editOrderDetails()
{
    makeAjaxCall(
        baseurl+'/orderoutbound/editorderdetails',
        'orderID='+orderID+'&customerReference='+("#orderReference").val()+'&email='+$("#emailAddress").val(),
        function(data){
            if(data.success)
            {
                $("#editOrderDetailsErrorDiv").html(successDiv(data.generalMessage));
                $(".customerReferenceSpan").html(data.order.customerReference);
                $(".emailSpan").html(data.order.emailAddress);

            }else{
                $("#editOrderDetailsErrorDiv").html(errorDiv(data.generalMessage));
                $("#emailAddressErrorDiv").html(data.errors.emailAddress);                  
            }
        }, 
        function(data) {
            $("#editOrderDetailsErrorDiv").html(errorDiv("There was an error.."));
        }
    );
}
//END EDIT ORDER DETAILS

//################ END PAGE FUNCTIONS ################

$(function() {

// EDIT ORDER DETAILS DIALOG
        $("#editOrderDetailsDialog").dialog('destroy').dialog({
            autoOpen: false,
            title: 'Edit Order Details',
            closeOnEscape: true,
            width: 500,
            height: 300,
            buttons:{ 
                "Save": function() { editOrderDetails(); },
                "Cancel": function() { $(this).dialog("close"); }
            }
        });
// END EDIT ORDER DETAILS DIALOG
});



//-->

</script>

Answer 1

You are missing a $ in the call to makeAjaxCall.

'orderID='+orderID+'&customerReference='+("#orderReference").val()+'&email='+$("#emailAddress").val(),

Becomes:

'orderID='+orderID+'&customerReference='+$("#orderReference").val()+'&email='+$("#emailAddress").val(),