Question

I have a basic PHP function that I am working with. Sometimes, it is passed an array of variables, and other times it is just passed one variable. So, currently, I have something like this:

 <?
 function do_this($user_id_array) {
   $user_ids = array();
   foreach ($user_id_array as $single_user_id) {
       $sql = 'SELECT username FROM users
               WHERE id = $single_unit';
               while($row = mysql_fetch_assoc($result)) {
                   array_push($user_ids, $row['id'];        
               }
   }
   return $user_ids;
 }
 ?>

My issue is this: If I call the function and send it only one variable (and not an array), it (obviously) gives me the following error: Invalid argument supplied for foreach()

My question is: How can I change this function in the most efficient way with the least amount of code? Do I have to use an if is_array() statement and just create 2 SELECT statements, one for each case (array and non-array)?

Many thanks!

Answer 1

wow. that’s a lot of queries. What about to delete foreach and do something like

if (is_array($user_id_array)){
    $sql = 'SELECT username,id FROM users
               WHERE id IN ('.implode(",", $user_id_array).')';
    $result = mysql_query($sql);

    while($row = mysql_fetch_assoc($result)){
        $users[$row['id']] = $row;
    }

}