Home/ Questions/Q 573133
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-13T13:41:31+00:00

I have a bug in this program, and I keep coming back to these

  • 0

I have a bug in this program, and I keep coming back to these two functions, but they look right to me. Anything wrong here?

long visual_time_get_msec(VisTime *time_)
{
    visual_log_return_val_if_fail(time_ != NULL, 0);

    return time_->tv_sec * 1000 + time_->tv_usec / 1000;
}


int visual_time_set_from_msec(VisTime *time_, long msec)
{
    visual_log_return_val_if_fail(time_ != NULL, -VISUAL_ERROR_TIME_NULL);


    long sec = msec / 1000;
    long usec = 0;

    visual_time_set(time_, sec, usec);

    return VISUAL_OK;
}
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    visual_time_set_from_msec doesnt look right…

    if someone calls visual_time_set_from_msec(time, 999), then your struct will be set to zero, rather the 999,000us.

    What you should do is:

    // Calculate number of seconds
long sec = msec / 1000; 
// Calculate remainding microseconds after number of seconds is taken in to account
long usec = (msec - 1000*sec) * 1000;

    it really depends on your inputs, but thats my 2 cents 🙂

    • 0