Question

I have a class that spans over two files. It is declared in a declare.h file and defined in define.cpp file.

define.h

class A{
    public: int a;
            void func(){ a = some_other_func(); }
             A();
};

define.cpp

A::A(){
    a =0;
}

The overall idea is to initialize a variable in constructor before using it in an inline function. But the constructor definition and function definition are in different files. Is there any issue with this?

Answer 1

There is absolutely no issue with the declaration/definition separation, provided declare.h is included in define.cpp. But the usulal practice is for implementation files to have the same name as declaration files, bar the suffix. So your case could be A.h and A.cpp.

However, there is an issue with the initialization of member variable a itself. You may want to initialize int a in the constructor initialization list:

A::A() : a(0) {}

In your code, it is not being initialized at all . You are creating and initializing a local variable called a a local variable in the body of the constructor. Presumably that is not what you intended.