Question

I have a double foreach loop and want to speed it up by making it one loop instead of two.

The idea is that it takes one element from the dictionary and compares it against all elements in the dictionary

foreach (KeyValuePair<Int64, string> kvp in originCounts)
{
    foreach (KeyValuePair<Int64, string> testkvp in originCounts)
    {
    //Run Comparison on testkvp ad kvp
    }
}

I want to turn this into one loop, any suggestions?

Answer 1

You can use Enumerable.All to check if all elements are the same:

var firstID = originCounts.First().Value.UserID;
bool allEquals = originCounts.Skip(1).All(o => o.Value.UserID == firstID);

It seems that this is what you actually want.

I’ve just picked out a field of your class in the duplicate question that sounds as a reasonable identifier.

public class MyObject 
{
    public string FirstName{ get; set; }
    public string LastName{ get; set; }
    public int UserID { get; set; }
    public string Address { get; set; }
}

Edit: According to your comment you want to determine if any of the objects’ fields is different to the same field of another object.

var first = originCounts.First().Value;
bool allEquals = originCounts.Skip(1).All(o =>
                o.Value.FirstName == first.FirstName
             && o.Value.LastName  == first.LastName
             && o.Value.UserID    == first.UserID
             && o.Value.Address   == first.Address);