Question

I have a Excel file with multiple tabs. I have a worksheet with some code which is working fine. This code also refers to data on some “master” tabs. I need to duplicate this sheet so I moved the common functions from there to a module. Now I get a VBA 1004 error when trying to access a range on the same worksheet.

 Dim selectedRange As Range
 Set selectedRange = Worksheets(name).Range("A1", _
 Range("A" & Rows.count).End(xlUp)) 'Error Line

This code worked fine till I moved it to a module. It works if I put a

Worksheets(name).Select 

before it, but I will have to do it too many times. Based on this query: VBA error 1004 – select method of range class failed
the code should work fine without a .Select. And it does as long as the code is within the worksheet. Why does moving code to a module create a problem?

Answer 1

U use Range and Rows properties without an object qualifier. When used without an object qualifier, this properties are a shortcut for ActiveSheet.Range / ActiveSheet.Rows.

So the code does this:

Worksheets(Name).Range("A1", ActiveSheet.Range("A" & ActiveSheet.Rows.Count).End(xlUp))

But Worksheets(name) could be different from active sheet so better is:

Worksheets(Name).Range("A1", Worksheets(Name).Range("A" & Worksheets(Name).Rows.Count).End(xlUp))

In With-End With block:

With Worksheets(name)
      Set selectedRange = .Range("A1", .Range("A" & .Rows.Count).End(xlUp))
End With

So it is ensured that the Range/Rows properties are applied on Worksheets(name) worksheet object.