Question

i have a file named “hello.txt” which has the content “Hello,there!”.
I want to remove the “,” and “!” and then print the new content.

With the code i made ,the program runs without errors but ,it erases all the contents and leaves an empty file.

def myfunc(filename):
filename=open('hello.txt','r')  
lines=filename.readlines()
filename.close()
filename=open('hello.txt','w')
for line in lines:
     for punc in ".!":
        line=line.replace(punc,"")
filename.close()


myfunc("hello")

Please,don’t use high level commands.
Thanks!

Answer 1

you should print the modified content line by line, not only at the end.

for line in lines:
    for punc in ",!":

        # note that we're assigning to line again
        # because we're executing this once for
        # each character
        line=line.replace(punc,"")

    # write the transformed line back to the file once ALL characters are replaced
    #
    # note that line still contains the newline character at the end

    # python 3
    # print(line,end="")

    # python 2.x
    print >> filename, line,

    # python 2.x alternative
    # filename.write(line)

By the way, naming a file handle filename is confusing.