Question

I have a form being validated in the following manner:

//Clear all variables
$formCheck = '';
$rep = '';
$name = '';
$department = '';
$location = '';
$email = '';
$phone = '';
$type = '';
$drink = '';
$notes = '';
$lastVisited = '';
$nextVisit = '';

$clean_formCheck = '';
$clean_rep = '';
$clean_name = '';
$clean_department = '';
$clean_location = '';
$clean_email = '';
$clean_phone = '';
$clean_type = '';
$clean_drink = '';
$clean_notes = '';
$clean_lastVisited = '';
$clean_nextVisit = '';

function validateRep($rep){
...some code...
}

$formCheck = $_POST["formCheck"];
$rep = $_POST["rep"];
$name = $_POST["name"];
$department = $_POST["department"];
$location = $_POST["location"];
$email = $_POST["email"];
$phone = $_POST["phone"];
$type = $_POST["type"];
$drink = $_POST["drink"];
$notes = $_POST["notes"];
$lastVisited = $_POST["lastVisited"];
$nextVisit = $_POST["nextVisit"];

if (validateRep($rep)){
    $clean_rep = $rep;
}else{
    echo "Invalid Rep";
    exit();
}
//.....and so on......

I was wondering if it would be more efficient / cleaner to validate using an an array instead of individual variable? If so, how would I go about that, and how would I write the different validation functions all in one (eg. right now I have a separate function to validate each field), would it be possible with a loop through the array? i was experimenting and so far this is what I have:

$unclean['formCheck'] = $_POST["formCheck"];
$unclean['rep'] = $_POST["rep"];
$unclean['name'] = $_POST["name"];
$unclean['department'] = $_POST["department"];
$unclean['location'] = $_POST["location"];
$unclean['email'] = $_POST["email"];
$unclean['phone'] = $_POST["phone"];
$unclean['type'] = $_POST["type"];
$unclean['drink'] = $_POST["drink"];
$unclean['notes'] = $_POST["notes"];
$unclean['lastVisited'] = $_POST["lastVisited"];
$unclean['nextVisit'] = $_POST["nextVisit"];


$clean = array(
        'rep', 'name', 'department', 'location', 'email', 'phone', 'type', 'drink', 'lastVisited', 'nextVisit',
);

but I’m not sure how to proceed from here.

Answer 1

I would use something along these lines… Just coded this very quickly, basically you create validation functions that match the post fields and return true or false if the validation passed. e.g. validate_department, validate_type, validate_drink, etc. Will work if your post data doesn’t have any strange characters in (which so far it doesn’t)

$post_fields = array('rep',
                      'name',
                      'department',
                      'location',
                      'email',
                      'phone',
                      'type',
                      'drink',
                      'lastVisited',
                      'nextVisit'
               );

$validate = new Validate();

foreach ($post_fields as $post_var)
{
  if (isset($_POST[$post_var]))
   {
      $validate->validate_data($post_var, $_POST[$post_var]);
   }
}

if ($validate->all_fields_valid() === true)
{
  echo 'congrats, all validation passed!';
}
else
{
   echo 'oh no! error in validation process. please see below errors: <p>' .
         $validate->get_error_msg() . '</p>';
}

And the validate class… Use $errorMsg to see the error messages should you run into any issues

class Validate
{
  var $valid = 0,
      $error = 0,
      $errorMsg = '';

  function validate_data($var, $data)
  {
    if (method_exists($this, 'validate_'.$var))
    {
      if (call_user_func(array($this, 'validate_'.$var), $data) === true)
      {
        $this->valid++;
      }
      else
      {
        $this->throwError('validation for: "'.$var.'" was not considered valid');
      }
    }
    else
    {
      $this->throwError('validation function for: "'.$var.'" does not exist');
    }
  }

  function throwError($msg = '')
  {
    if ($msg) $this->errorMsg .= $msg . '<br/>';
    $this->error++;
  }

  function all_fields_valid()
  {
    if (!$this->error) return true;
    return false;
  }

/***********************************************
*************************************************
 Custom validation functions go below here
   Function format: validate_<postFieldName>
   Returns: true or false if the data passed is valid or not
*************************************************
*************************************************/

  function validate_type($type)
  {
    if (is_numeric($type)) return true;
    return false;
  }

  function validate_lastVisited($data)
  {


  }

  //etc...............

}